Message 145746 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	mark.dickinson
Recipients	ezio.melotti, mark.dickinson, smarnach
Date	2011-10-17.18:23:40
SpamBayes Score	1.4325148e-09
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
The new patch looks fine; I'd still like to have the more explicit reference counting in range_hash (see replies on Rietveld). A few more things: - The patch needs a Misc/NEWS entry before committing; it probably deserves a line in Doc/whatsnew/3.3.rst, too. - The doc update should have a ".. versionchanged:: 3.3" note. - Maybe the range_compare function could be renamed to something that makes it clearer it's just doing an equality comparison rather than a generalized comparison. 'range_equality_check'? Or just 'range_equal' or 'range_equality'?

The new patch looks fine;  I'd still like to have the more explicit reference counting in range_hash (see replies on Rietveld).

A few more things:

- The patch needs a Misc/NEWS entry before committing;  it probably deserves a line in Doc/whatsnew/3.3.rst, too.

- The doc update should have a ".. versionchanged:: 3.3" note.

- Maybe the range_compare function could be renamed to something that makes it clearer it's just doing an equality comparison rather than a generalized comparison.  'range_equality_check'?  Or just 'range_equal' or 'range_equality'?

History
Date	User	Action	Args
2011-10-17 18:23:41	mark.dickinson	set	recipients: + mark.dickinson, ezio.melotti, smarnach
2011-10-17 18:23:41	mark.dickinson	set	messageid: <[email protected]>
2011-10-17 18:23:41	mark.dickinson	link	issue13201 messages
2011-10-17 18:23:40	mark.dickinson	create