Message 207833 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vajrasky
Recipients	christian.heimes, larry, vajrasky
Date	2014-01-10.04:06:55
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
>Rule 1: Argument Clinic handles all argument parsing for you. Your "impl" function should never call PyArg_ParseTuple or PyArg_ParseTupleAndKeywords. Ah, got it. Here is the third patch. Everything works fine except for the issue whether sha1 constructor should accept None value or not. Right now, after clinic, it accepts it. So _sha1.sha1() is same as _sha1.sha1(string=None).

>Rule 1: Argument Clinic handles all argument parsing for you.  Your "impl" function should never call PyArg_ParseTuple or PyArg_ParseTupleAndKeywords.

Ah, got it. Here is the third patch. Everything works fine except for the issue whether sha1 constructor should accept None value or not. Right now, after clinic, it accepts it. So _sha1.sha1() is same as _sha1.sha1(string=None).

History
Date	User	Action	Args
2014-01-10 04:06:56	vajrasky	set	recipients: + vajrasky, larry, christian.heimes
2014-01-10 04:06:56	vajrasky	set	messageid: <[email protected]>
2014-01-10 04:06:55	vajrasky	link	issue20173 messages
2014-01-10 04:06:55	vajrasky	create