Message 208547 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	yselivanov
Recipients	Claudiu.Popa, Yury.Selivanov, larry, michael.foord, ncoghlan, terry.reedy, yselivanov
Date	2014-01-20.16:02:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> Instead of keeping the check, we could just unconditionally convert exceptions from the signature call to a TypeError in order to maintain compatibility with the old external behaviour. Agreed. See the new patch (getargsspec_02.patch) Unfortunately, we have to keep the old 'ismethod' check in place for backwards compatibility purposes. Larry, The attached patch contains one failing unit-test: 'inspect.signature' returns 'None' for '_testapi.docstring_no_signature'. It should instead raise a ValueError.

> Instead of keeping the check, we could just unconditionally convert exceptions from the signature call to a TypeError in order to maintain compatibility with the old external behaviour.

Agreed. See the new patch (getargsspec_02.patch)

Unfortunately, we have to keep the old 'ismethod' check in place for backwards compatibility purposes.

Larry,

The attached patch contains one failing unit-test: 'inspect.signature' returns 'None' for '_testapi.docstring_no_signature'. It should instead raise a ValueError.

History
Date	User	Action	Args
2014-01-20 16:02:06	yselivanov	set	recipients: + yselivanov, terry.reedy, ncoghlan, larry, michael.foord, Claudiu.Popa, Yury.Selivanov
2014-01-20 16:02:06	yselivanov	set	messageid: <[email protected]>
2014-01-20 16:02:06	yselivanov	link	issue17481 messages
2014-01-20 16:02:06	yselivanov	create