Message 228753 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	geertj
Recipients	alex, geertj, pitrou, vstinner
Date	2014-10-07.02:10:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> newPySSLSocket() expects a char* string and use PyUnicode_Decode() to decode bytes. Yup, and this value is available as SSLSocket._sslobj.server_hostname. But SSLSocket.server_hostname is not this, it is what was passed to the constructor which can be a bytes instance. For total cleanness maybe the constructor should raise a TypeError if server_hostname is passes as a bytes.

> newPySSLSocket() expects a char* string and use PyUnicode_Decode() to decode bytes.

Yup, and this value is available as SSLSocket._sslobj.server_hostname. But SSLSocket.server_hostname is not this, it is what was passed to the constructor which can be a bytes instance.

For total cleanness maybe the constructor should raise a TypeError if server_hostname is passes as a bytes.

History
Date	User	Action	Args
2014-10-07 02:10:34	geertj	set	recipients: + geertj, pitrou, vstinner, alex
2014-10-07 02:10:33	geertj	set	messageid: <[email protected]>
2014-10-07 02:10:33	geertj	link	issue22564 messages
2014-10-07 02:10:33	geertj	create