Message 239741 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	neologix, pitrou, python-dev, serhiy.storchaka, vstinner
Date	2015-03-31.17:39:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<CAMpsgwaiWziTPy3fkvcjbhQcXNS6nyX_3PdzYrDkZRuhU1ASyg@mail.gmail.com>
In-reply-to	<[email protected]>

Content
Le mardi 31 mars 2015, Roundup Robot <[email protected]> a écrit : > > New changeset c59d81b802f8 by Victor Stinner in branch 'default': > Issue #23618: Refactor internal_connect() > https://hg.python.org/cpython/rev/c59d81b802f8 > Oh I forgot to add an #ifdef for socklen_t. I didn't get a warning, so socklen_t is probably an int. Getsockopt() uses a int* for the value length. I also forgot to drop the comment before SetLastError(), it's no more revelant.

Le mardi 31 mars 2015, Roundup Robot <[email protected]> a écrit :
>
> New changeset c59d81b802f8 by Victor Stinner in branch 'default':
> Issue #23618: Refactor internal_connect()
> https://hg.python.org/cpython/rev/c59d81b802f8
>

Oh I forgot to add an #ifdef for socklen_t. I didn't get a warning, so
socklen_t is probably an int. Getsockopt() uses a int* for the value length.

I also forgot to drop the comment before SetLastError(), it's no more
revelant.

History
Date	User	Action	Args
2015-03-31 17:39:56	vstinner	set	recipients: + vstinner, pitrou, neologix, python-dev, serhiy.storchaka
2015-03-31 17:39:56	vstinner	link	issue23618 messages
2015-03-31 17:39:56	vstinner	create