Message260448
I do wonder if NotImplementedError is the right exception. According to the documentation it is derived from RuntimeError and is meant for abstract methods, i.e. it is a programmer error. Other cases in urllib.request raise ValueError (e.g. AbstractBasicAuthHandler), which is fairly normal for protocol errors like this.
Also it would be nice to add a test case for the bug fix. |
|
| Date |
User |
Action |
Args |
| 2016-02-18 10:57:47 | martin.panter | set | recipients:
+ martin.panter, georg.brandl, jjlee, orsenthil, kristjan.jonsson, christian.heimes, cjw296, bwmcadams, dieresys, r.david.murray, santoso.wijaya, deronnax |
| 2016-02-18 10:57:47 | martin.panter | set | messageid: <[email protected]> |
| 2016-02-18 10:57:47 | martin.panter | link | issue2202 messages |
| 2016-02-18 10:57:46 | martin.panter | create | |
|