➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients ncoghlan, vstinner
Date 2017-03-27.12:59:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <[email protected]>
In-reply-to
Content 
Tools/scripts/patchcheck.py still checks isdir() in get_base_branch():

@status("Getting base branch for PR",
        info=lambda x: x if x is not None else "not a PR branch")
def get_base_branch():
    if not os.path.isdir(os.path.join(SRCDIR, '.git')):
        # Not a git checkout, so there's no base branch
        return None
    ...

Was it deliberate to not change this line?
History
Date User Action Args
2017-03-27 12:59:28vstinnersetrecipients: + vstinner, ncoghlan
2017-03-27 12:59:28vstinnersetmessageid: <[email protected]>
2017-03-27 12:59:28vstinnerlinkissue29798 messages
2017-03-27 12:59:27vstinnercreate