Message 310329 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	Mark.Shannon, gvanrossum, levkivskyi, rhettinger, serhiy.storchaka, yselivanov
Date	2018-01-20.07:49:50
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> This PR moves the constant for the name from `co_names` to `co_consts`. There is no duplication. But if there is an initializer, the name is left in `co_names` too. I don't think this (as well as possible performance difference) is important. My only concerns are about subtle behavior differences. For example, is the name always interned (even if long or non-ASCII)? Does any code depend on interning keys in __annotations__? (There is a code that depends on interning keys in type.__dict__).

> This PR moves the constant for the name from `co_names` to `co_consts`. There is no duplication.

But if there is an initializer, the name is left in `co_names` too.

I don't think this (as well as possible performance difference) is important. My only concerns are about subtle behavior differences.

For example, is the name always interned (even if long or non-ASCII)? Does any code depend on interning keys in __annotations__? (There is a code that depends on interning keys in type.__dict__).

History
Date	User	Action	Args
2018-01-20 07:49:50	serhiy.storchaka	set	recipients: + serhiy.storchaka, gvanrossum, rhettinger, Mark.Shannon, yselivanov, levkivskyi
2018-01-20 07:49:50	serhiy.storchaka	set	messageid: <[email protected]>
2018-01-20 07:49:50	serhiy.storchaka	link	issue32550 messages
2018-01-20 07:49:50	serhiy.storchaka	create