Message 346292 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	joernheissler
Recipients	emilyemorehouse, eric.smith, gvanrossum, joernheissler, koobs, miss-islington, nedbat, pablogsal, rhettinger, steven.daprano, tim.peters, veky, willingc, xtreak
Date	2019-06-22.19:24:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
My working theory: The change modifies the MAP_ADD instruction and also what the instruction expects to find on the stack. When .pyc files are kept, the code generates the old stack layout (TOS=key, TOS1=value), but cpython will assume it's the other way round. I.e. all .pyc files created before the change won't work with later cpython versions, and vice versa. I assume the build bots don't remove *.pyc files. How large an issue is that?

My working theory:

The change modifies the MAP_ADD instruction and also what the instruction expects to find on the stack.
When *.pyc files are kept, the code generates the old stack layout (TOS=key, TOS1=value), but cpython will assume it's the other way round.

I.e. all *.pyc files created before the change won't work with later cpython versions, and vice versa.

I assume the build bots don't remove *.pyc files.

How large an issue is that?

History
Date	User	Action	Args
2019-06-22 19:24:39	joernheissler	set	recipients: + joernheissler, gvanrossum, tim.peters, rhettinger, eric.smith, nedbat, steven.daprano, koobs, willingc, veky, emilyemorehouse, pablogsal, miss-islington, xtreak
2019-06-22 19:24:39	joernheissler	set	messageid: <[email protected]>
2019-06-22 19:24:39	joernheissler	link	issue35224 messages
2019-06-22 19:24:39	joernheissler	create