Message357893
> The main problem that I see here is that, in Windows (not POSIX), ntpath.ismount fails to verify that a potential mount point is an existing directory via os.stat and stat.S_ISDIR. ... This would be a breaking change, but I think it's important enough.
So essentially, you say the check should always be "ntpath.isdir(d) and ntpath.ismount(d)" (plus the non-breaking improvements to ismount)? And we should just do the isdir() inside ismount() because otherwise the result is nonsense.
I'm inclined to agree, and I'm not concerned about breaking a nonsense result.
On the other hand, this will make ntpath.ismount meaningless on POSIX, as it will always require real access to the file system. Is it worth having a "pure" implementation for best effort in this case? Based on the splitdrive() patterns we support (plus the fixes to support them properly)? |
|
| Date |
User |
Action |
Args |
| 2019-12-05 23:33:55 | steve.dower | set | recipients:
+ steve.dower, paul.moore, tim.golden, zach.ware, eryksun, lazka, jainankur |
| 2019-12-05 23:33:55 | steve.dower | set | messageid: <[email protected]> |
| 2019-12-05 23:33:54 | steve.dower | link | issue38948 messages |
| 2019-12-05 23:33:54 | steve.dower | create | |
|