This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.snow
Recipients eric.snow, shihai1991, vstinner
Date 2020-05-05.15:11:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <[email protected]>
In-reply-to
Content
FWIW, I think it would make sense to keep "signals_pending" under _PyRuntimeState rather than moving it to PyInterpreterState.

Signals are only handled by the main interpreter (in its main thread).  Even though "signals_pending" is useful to only one interpreter in the runtime, making it per-interpreter sends the wrong message that it is significant at that level.  This may be confusing to readers of the code.

At the very least there should be a clear comment with the field in Include/internal/pycore_interp.h explaining how it is only used by the main interpreter and why we made it per-interpreter anyway.
History
Date User Action Args
2020-05-05 15:11:26eric.snowsetrecipients: + eric.snow, vstinner, shihai1991
2020-05-05 15:11:26eric.snowsetmessageid: <[email protected]>
2020-05-05 15:11:26eric.snowlinkissue40513 messages
2020-05-05 15:11:26eric.snowcreate