Message 58703 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	christian.heimes
Recipients	Rhamphoryncus, christian.heimes
Date	2007-12-17.19:53:43
SpamBayes Score	0.18775576
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to	<[email protected]>

Content
Adam Olsen wrote: > You have: > #define Py_NAN Py_HUGE_VAL * 0 > I think this would be safer as: > #define Py_NAN (Py_HUGE_VAL * 0) > > For instance, in code that may do "a / Py_NAN". You are right! Fixed > Those manual string copies (*cp++ = 'n';) are ugly. Can't you use > strcpy() instead? Done Christian

Adam Olsen wrote:
> You have:
> #define Py_NAN Py_HUGE_VAL * 0
> I think this would be safer as:
> #define Py_NAN (Py_HUGE_VAL * 0)
> 
> For instance, in code that may do "a / Py_NAN".

You are right! Fixed

> Those manual string copies (*cp++ = 'n';) are ugly.  Can't you use
> strcpy() instead?

Done

Christian

History
Date	User	Action	Args
2007-12-17 19:53:44	christian.heimes	set	spambayes_score: 0.187756 -> 0.18775576 recipients: + christian.heimes, Rhamphoryncus
2007-12-17 19:53:44	christian.heimes	link	issue1635 messages
2007-12-17 19:53:43	christian.heimes	create