➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients _doublep, belopolsky, benjamin.peterson, gvanrossum, nnorwitz, rhettinger
Date 2008-02-25.23:37:27
SpamBayes Score 0.012108425
Marked as misclassified No
Message-id <[email protected]>
In-reply-to
Content 
Attached patch adds test_elim_unreachable() unit test.  Last two 
assertions should fail with unpatched python.

I am still trying to convince myself that the transformation are 
correct.

> I propose that codestr[] array is made one byte
> longer and RETURN_VALUE opcode wrote in that extra byte.

I don't think that will be correct.  Did you consider the following 
comment?

        /* Verify that RETURN_VALUE terminates the codestring.  This 
allows 
           the various transformation patterns to look ahead several 
           instructions without additional checks to make sure they are 
not 
           looking beyond the end of the code string. 
        */ 
        if (codestr[codelen-1] != RETURN_VALUE) 
                goto exitUnchanged;
History
Date User Action Args
2008-02-25 23:37:29belopolskysetspambayes_score: 0.0121084 -> 0.012108425
recipients: + belopolsky, gvanrossum, nnorwitz, rhettinger, _doublep, benjamin.peterson
2008-02-25 23:37:29belopolskysetspambayes_score: 0.0121084 -> 0.0121084
messageid: <[email protected]>
2008-02-25 23:37:28belopolskylinkissue1394 messages
2008-02-25 23:37:27belopolskycreate