➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nnorwitz
Recipients _doublep, belopolsky, benjamin.peterson, gvanrossum, nnorwitz, rhettinger
Date 2008-02-26.05:58:47
SpamBayes Score 0.0026728816
Marked as misclassified No
Message-id <[email protected]>
In-reply-to
Content 
Can you add more tests?  It seems that almost all the examples given in
this thread are good examples.  Also something like:

  while 1:
    if cond: return 1
    return 2
  return 3

There are a bunch more cases that could be added for where the code
should be optimized or might be optimized wrong that.

The #if 0 code should be removed in the patch.  Also, since
CONTINUE_LOOP is removed in this patch, it would be good to explicitly
add a test for that.  

This patch looks good to me, but I'll let Raymond decide.  Did all the
entire test suite run?  Note, you must remove all the .pyc files to test
this patch or change the MAGIC number in Python/import.c.
History
Date User Action Args
2008-02-26 05:58:48nnorwitzsetspambayes_score: 0.00267288 -> 0.0026728816
recipients: + nnorwitz, gvanrossum, rhettinger, belopolsky, _doublep, benjamin.peterson
2008-02-26 05:58:48nnorwitzsetspambayes_score: 0.00267288 -> 0.00267288
messageid: <[email protected]>
2008-02-26 05:58:47nnorwitzlinkissue1394 messages
2008-02-26 05:58:47nnorwitzcreate