Message 97873 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pakal
Recipients	pakal, pitrou
Date	2010-01-16.12:09:55
SpamBayes Score	2.965875e-05
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
Thanks for the detailed feedback. According to what you said (and to details found in python docs), the current _fileio.truncate is actually quite buggy -> no reference counting ops were done on posobj, even though it's sometimes retrieved from _portable_seek, and returned or not depending on rare error cases (SetEndOfFile failing etc.). Here is a patch fixing all that for python2.6, I've tested it manually in debug mode, and against memoryio/io/fileio tests ; hope it will be OK. As soon as this one is certified, I'll prepare a patch for python2.7

Thanks for the detailed feedback.

According to what you said (and to details found in python docs), the current _fileio.truncate is actually quite buggy -> no reference counting ops were done on posobj, even though it's sometimes retrieved from _portable_seek, and returned or not depending on rare error cases (SetEndOfFile failing etc.).

Here is a patch fixing all that for python2.6, I've tested it manually in debug mode, and against memoryio/io/fileio tests ; hope it will be OK.

As soon as this one is certified, I'll prepare a patch for python2.7

History
Date	User	Action	Args
2010-01-16 12:09:59	pakal	set	recipients: + pakal, pitrou
2010-01-16 12:09:59	pakal	set	messageid: <[email protected]>
2010-01-16 12:09:57	pakal	link	issue6939 messages
2010-01-16 12:09:57	pakal	create