➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jhylton
Recipients amaury.forgeotdarc, benjamin.peterson, cmcqueen1975, gvanrossum, jhylton, pje, rhettinger, terry.reedy
Date 2010-02-23.20:41:28
SpamBayes Score 4.03814e-07
Marked as misclassified No
Message-id <[email protected]>
In-reply-to <[email protected]>
Content 
The patch looks pretty good.

I'd factor out the common error-checking code (common between
LOAD_DEREF and DELETE_DEREF) into a helper function.

It would also be good to add some test cases.

Jeremy

On Tue, Feb 23, 2010 at 9:38 AM, Guido van Rossum
<[email protected]> wrote:
>
> Guido van Rossum <[email protected]> added the comment:
>
> I don't think so. It's very marginal.
>
> --Guido (on Android)
>
> On Feb 23, 2010 8:52 AM, "Amaury Forgeot d&apos;Arc" <[email protected]>
> wrote:
>
> Amaury Forgeot d'Arc <[email protected]> added the comment:
>
> The above patch adds a new opcode (DELETE_DEREF), does the Moratorium apply
> here?
>
> ----------
>
> _______________________________________
> Python tracker <[email protected]>
> <http://bugs.python...
>
> ----------
> Added file: http://bugs.python.org/file16341/unnamed
>
> _______________________________________
> Python tracker <[email protected]>
> <http://bugs.python.org/issue4617>
> _______________________________________
History
Date User Action Args
2010-02-23 20:41:29jhyltonsetrecipients: + jhylton, gvanrossum, rhettinger, terry.reedy, pje, amaury.forgeotdarc, benjamin.peterson, cmcqueen1975
2010-02-23 20:41:28jhyltonlinkissue4617 messages
2010-02-23 20:41:28jhyltoncreate