bpo-35431: Simplify negativity checks in math.comb and math.perm.#13870
Merged
mdickinson merged 1 commit intopython:masterfrom Jun 16, 2019
Merged
bpo-35431: Simplify negativity checks in math.comb and math.perm.#13870mdickinson merged 1 commit intopython:masterfrom
mdickinson merged 1 commit intopython:masterfrom
Conversation
mangrisano
approved these changes
Jun 6, 2019
c9bc189 to
7c310cf
Compare
Contributor
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-14125 is a backport of this pull request to the 3.8 branch. |
mdickinson
added a commit
that referenced
this pull request
Jun 16, 2019
…4125) (cherry picked from commit 45e0411) Co-authored-by: Mark Dickinson <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor code readability improvement: move the negativity checks for
k < 0inmath.combandmath.permup nearer the top of the functions.https://bugs.python.org/issue35431