bpo-37404: Raising value error if an SSLSocket is passed to asyncio functions#16457
Merged
miss-islington merged 5 commits intopython:masterfrom Dec 7, 2019
Merged
bpo-37404: Raising value error if an SSLSocket is passed to asyncio functions#16457miss-islington merged 5 commits intopython:masterfrom
miss-islington merged 5 commits intopython:masterfrom
Conversation
Contributor
Author
|
Adding @taleinat as a reviewer |
Contributor
|
I'm not very familiar with asyncio, but it seems to me that in these cases the code should raise an exception rather than emit a warning. A |
Member
|
Agree with @taleinat, a |
Contributor
|
Agree as well. |
Contributor
Author
Hi all, would fix it to throw a TypeError exception, I was following the thread in bpo - there was a discussion about sending a warning first instead of just throwing an exception without any notice first. Will commit a new version soon! |
Contributor
Author
|
Commited the new version: raising TypeError instead of a warning. |
Contributor
Author
|
@taleinat Maybe we can push this one as well? (been pending 2 months) |
taleinat
requested changes
Dec 1, 2019
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Sorry for letting this languish, that's definitely on me! Thanks for the reminder. For this, we'll also need to add a NEWS entry. You can use blurb-it to do so easily in the browser, or install locally with |
Contributor
Contributor
|
Sorry, I can't merge this PR. Reason: |
2 similar comments
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Thanks @idomic for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Contributor
|
Sorry @idomic, I had trouble checking out the |
asvetlov
approved these changes
Dec 7, 2019
Contributor
|
Sorry, I can't merge this PR. Reason: |
|
GH-17495 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 7, 2019
…unctions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <[email protected]>
|
GH-17496 is a backport of this pull request to the 3.8 branch. |
asvetlov
pushed a commit
to asvetlov/cpython
that referenced
this pull request
Dec 7, 2019
…ncio functions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Dec 7, 2019
…ncio functions (GH-16457) (#17496) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 7, 2019
…unctions (GH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <[email protected]>
|
|
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37404
Automerge-Triggered-By: @asvetlov