From dd3350a0178a9dc95cdabcdec7e0e902a880399b Mon Sep 17 00:00:00 2001 From: Johnny Najera Date: Sat, 30 Nov 2019 14:02:29 +0200 Subject: [PATCH 1/4] Fixing Escape key not bound to KeyPress event --- Lib/idlelib/autocomplete_w.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py index 5035e067392e5f..f20b6330997886 100644 --- a/Lib/idlelib/autocomplete_w.py +++ b/Lib/idlelib/autocomplete_w.py @@ -17,7 +17,7 @@ # before the default specific IDLE function KEYPRESS_SEQUENCES = ("", "", "", "", "", "", "", "", - "", "") + "", "", "") KEYRELEASE_VIRTUAL_EVENT_NAME = "<>" KEYRELEASE_SEQUENCE = "" LISTUPDATE_SEQUENCE = "" From 2bf76260d3a17ed2680469d39ce4056ef9fa145f Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Sat, 30 Nov 2019 12:10:36 +0000 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst diff --git a/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst new file mode 100644 index 00000000000000..fb2a6b0781e196 --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst @@ -0,0 +1 @@ +Fixing Idle autocomplete window doesn't close on Escape key \ No newline at end of file From fa35acf2fac91e032ba55dca582ecf85b309176f Mon Sep 17 00:00:00 2001 From: Johnny Najera Date: Sat, 30 Nov 2019 14:26:03 +0200 Subject: [PATCH 3/4] Grammar --- Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst index fb2a6b0781e196..68e9a76bfb86f7 100644 --- a/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst +++ b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst @@ -1 +1 @@ -Fixing Idle autocomplete window doesn't close on Escape key \ No newline at end of file +Fixing Idle autocomplete window doesn't close on Escape key. From 28730b427e11e32d436dfbfb669a0f356a0a5652 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Mon, 9 Dec 2019 17:56:41 -0500 Subject: [PATCH 4/4] News item. --- Lib/idlelib/NEWS.txt | 3 +++ Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 5eb77398d95e60..90e7d801535f59 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,9 @@ Released on 2020-10-05? ====================================== +bpo-38944: Excape key now closes IDLE completion windows. Patch by +Johnny Najera. + bpo-38862: 'Strip Trailing Whitespace' on the Format menu removes extra newlines at the end of non-shell files. diff --git a/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst index 68e9a76bfb86f7..38084fafd2f561 100644 --- a/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst +++ b/Misc/NEWS.d/next/IDLE/2019-11-30-12-10-36.bpo-38944._3xjKG.rst @@ -1 +1 @@ -Fixing Idle autocomplete window doesn't close on Escape key. +Excape key now closes IDLE completion windows. Patch by Johnny Najera.