Skip to content

bpo-40291: Add support for CAN_J1939 sockets#19538

Merged
miss-islington merged 1 commit intopython:masterfrom
karlding:bpo_40291_add_j1939_socket_support
Apr 29, 2020
Merged

bpo-40291: Add support for CAN_J1939 sockets#19538
miss-islington merged 1 commit intopython:masterfrom
karlding:bpo_40291_add_j1939_socket_support

Conversation

@karlding
Copy link
Copy Markdown
Contributor

@karlding karlding commented Apr 15, 2020

Add support for CAN_J1939 sockets that wrap SAE J1939 protocol
functionality provided by Linux 5.4+ kernels.

https://bugs.python.org/issue40291

Automerge-Triggered-By: @gvanrossum

Add support for CAN_J1939 sockets that wrap SAE J1939 protocol
functionality provided by Linux 5.4+ kernels.
@karlding karlding force-pushed the bpo_40291_add_j1939_socket_support branch from 100fd8d to 7ae7ef5 Compare April 19, 2020 19:03
@gvanrossum
Copy link
Copy Markdown
Member

The implementation looks reasonable to me.

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants