From 2be5af03a04e46849a8e8e352016de08222622ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Delfino?= Date: Sat, 22 Aug 2020 11:39:08 -0300 Subject: [PATCH 1/4] Add link to FileHandler --- Doc/library/logging.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doc/library/logging.rst b/Doc/library/logging.rst index 3ff67f76cc3c5a..b5dd74ef8c1136 100644 --- a/Doc/library/logging.rst +++ b/Doc/library/logging.rst @@ -1166,9 +1166,9 @@ functions. +--------------+---------------------------------------------+ | Format | Description | +==============+=============================================+ - | *filename* | Specifies that a FileHandler be created, | - | | using the specified filename, rather than a | - | | StreamHandler. | + | *filename* | Specifies that a class:`FileHandler` be | + | | created, using the specified filename, | + | | rather than a StreamHandler. | +--------------+---------------------------------------------+ | *filemode* | If *filename* is specified, open the file | | | in this :ref:`mode `. Defaults | From df47a4f30cba21d28e0b038464112712ff752473 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Delfino?= Date: Sat, 22 Aug 2020 11:46:03 -0300 Subject: [PATCH 2/4] Add link to FileHandler --- Doc/library/logging.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/library/logging.rst b/Doc/library/logging.rst index b5dd74ef8c1136..9e64a9f981d440 100644 --- a/Doc/library/logging.rst +++ b/Doc/library/logging.rst @@ -1166,7 +1166,7 @@ functions. +--------------+---------------------------------------------+ | Format | Description | +==============+=============================================+ - | *filename* | Specifies that a class:`FileHandler` be | + | *filename* | Specifies that a :class:`FileHandler` be | | | created, using the specified filename, | | | rather than a StreamHandler. | +--------------+---------------------------------------------+ From b759d8945505c8010744eea2c6831190a0f869a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Delfino?= Date: Sun, 23 Aug 2020 11:41:10 -0300 Subject: [PATCH 3/4] Address comment from Vinay --- Doc/library/logging.rst | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/Doc/library/logging.rst b/Doc/library/logging.rst index 9e64a9f981d440..d721dad1902ddb 100644 --- a/Doc/library/logging.rst +++ b/Doc/library/logging.rst @@ -1168,7 +1168,7 @@ functions. +==============+=============================================+ | *filename* | Specifies that a :class:`FileHandler` be | | | created, using the specified filename, | - | | rather than a StreamHandler. | + | | rather than a :class:`StreamHandler`. | +--------------+---------------------------------------------+ | *filemode* | If *filename* is specified, open the file | | | in this :ref:`mode `. Defaults | @@ -1192,9 +1192,10 @@ functions. | | :ref:`level `. | +--------------+---------------------------------------------+ | *stream* | Use the specified stream to initialize the | - | | StreamHandler. Note that this argument is | - | | incompatible with *filename* - if both | - | | are present, a ``ValueError`` is raised. | + | | :class:`StreamHandler`. Note that this | + | | argument is incompatible with *filename* - | + | | if both are present, a ``ValueError`` is | + | | raised. | +--------------+---------------------------------------------+ | *handlers* | If specified, this should be an iterable of | | | already created handlers to add to the root | @@ -1213,18 +1214,18 @@ functions. +--------------+---------------------------------------------+ | *encoding* | If this keyword argument is specified along | | | with *filename*, its value is used when the | - | | FileHandler is created, and thus used when | - | | opening the output file. | + | | :class:`FileHandler` is created, and thus | + | | used when opening the output file. | +--------------+---------------------------------------------+ | *errors* | If this keyword argument is specified along | | | with *filename*, its value is used when the | - | | FileHandler is created, and thus used when | - | | opening the output file. If not specified, | - | | the value 'backslashreplace' is used. Note | - | | that if ``None`` is specified, it will be | - | | passed as such to func:`open`, which means | - | | that it will be treated the same as passing | - | | 'errors'. | + | | :class:`FileHandler` is created, and thus | + | | used when opening the output file. If not | + | | specified, the value 'backslashreplace' is | + | | used. Note that if ``None`` is specified, | + | | it will be passed as such to func:`open`, | + | | which means that it will be treated the | + | | same as passing 'errors'. | +--------------+---------------------------------------------+ .. versionchanged:: 3.2 From a901a96700c46d20aef700b968b2fce6c3f81bf0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Delfino?= Date: Mon, 31 Aug 2020 15:19:28 -0300 Subject: [PATCH 4/4]