bpo-24882: eagerly spawn threads in ThreadPoolExecutor#6530
Closed
iUnknwn wants to merge 1 commit intopython:masterfrom
Closed
bpo-24882: eagerly spawn threads in ThreadPoolExecutor#6530iUnknwn wants to merge 1 commit intopython:masterfrom
iUnknwn wants to merge 1 commit intopython:masterfrom
Conversation
This is an alternate solution to issue 24882. At the suggestion of pitrou, instead of implementing idle thread handling logic, this change modifies ThreadPoolExecutor to spawn all worker threads on creation.
methane
reviewed
Apr 19, 2018
| thread_name = '%s_%d' % (self._thread_name_prefix or self, | ||
| thread_num) | ||
| t = threading.Thread(name=thread_name, target=_worker, | ||
| args=(weakref.ref(self, weakref_cb), |
Member
There was a problem hiding this comment.
Can't the weakref shared among all threads?
If weakref_cb can call q.put(None) max_workers times. Or we can use __del__ method for it.
Member
There was a problem hiding this comment.
Oh, there is no need to call q.put(None) max_workers times.
First worker received None calls q.put(None) for next worker.
cpython/Lib/concurrent/futures/thread.py
Lines 94 to 95 in 6952482
Member
|
Closing in favor of #6375. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate solution to issue 24882 (and a replacement for PR #6375). At the suggestion
of @pitrou , instead of implementing idle thread handling logic, this change modifies ThreadPoolExecutor to spawn all worker threads on creation - removing all the logic entirely.
Also updates relevant test cases.
https://bugs.python.org/issue24882