Skip to content

gh-59795: distinct python-config from pkg-config python#737

Closed
haubi wants to merge 1 commit intopython:mainfrom
haubi:bpo-15590/master
Closed

gh-59795: distinct python-config from pkg-config python#737
haubi wants to merge 1 commit intopython:mainfrom
haubi:bpo-15590/master

Conversation

@haubi
Copy link
Copy Markdown

@haubi haubi commented Mar 20, 2017 •
edited by bedevere-bot
Loading

Fix output of 'python-config' for creating loadable Python modules.
Fix output of 'pkg-config python' for linking against the interpreter.

@haubi
bpo-15590: distinct python-config from pkg-config python
f9aa401 
Fix output of 'python-config' for creating loadable Python modules.
Fix output of 'pkg-config python' for linking against the interpreter.
@mention-bot
Copy link
Copy Markdown

mention-bot commented Mar 20, 2017

@haubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ned-deily and @loewis to be potential reviewers.

@ned-deily ned-deily self-requested a review March 20, 2017 19:07
@adamjstewart adamjstewart mentioned this pull request Apr 28, 2017
Closed
auvipy
auvipy suggested changes May 31, 2019
View reviewed changes
Copy link
Copy Markdown

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please re base this or want new taker for this?

@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented May 31, 2019 •
edited by erlend-aasland
Loading

See more recent bpo-36721 (#80902) which also addresses this area.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jun 2, 2019 •
edited by erlend-aasland
Loading

See more recent bpo-36721 (#80902) which also addresses this area.

I'm not sure that bpo-36721 (#80902) is related. Misc/python-config.sh.in still uses SYSLIBS, whereas Misc/python.pc.in doesn't.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 28, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
iritkatriel
iritkatriel requested changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 29, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 30, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 31, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2022
@haubi
Copy link
Copy Markdown
Author

haubi commented Jan 9, 2023

Unfortunately, meanwhile I have moved on to completely different tasks, and have neither the environment nor the time any more to look into that again: Feel free to pick up!

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 10, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 10, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 10, 2023
@erlend-aasland erlend-aasland changed the title bpo-15590: distinct python-config from pkg-config python gh-59795: distinct python-config from pkg-config python Feb 21, 2023
@erlend-aasland
Copy link
Copy Markdown
Contributor

erlend-aasland commented Feb 21, 2023

Meta: added GitHub links to OP and comments for easier navigation.

@erlend-aasland
Copy link
Copy Markdown
Contributor

erlend-aasland commented Feb 21, 2023

Unfortunately, meanwhile I have moved on to completely different tasks, and have neither the environment nor the time any more to look into that again: Feel free to pick up!

In that case, I propose to close this PR. If anybody wants to pick this up, they'll be better off by starting from scratch; the build system has seen huge changes the recent years.

We should also consider closing the linked issue; I'm unsure if this is a real problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

@ned-deily ned-deily Awaiting requested review from ned-deily

+1 more reviewer

@auvipy auvipy auvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.