Skip to content

bpo-23699: Use a macro to reduce boilerplate code in rich comparison functions#793

Merged
ncoghlan merged 1 commit intopython:masterfrom
stratakis:richcompare_macro
Nov 2, 2017
Merged

bpo-23699: Use a macro to reduce boilerplate code in rich comparison functions#793
ncoghlan merged 1 commit intopython:masterfrom
stratakis:richcompare_macro

Conversation

@stratakis
Copy link
Copy Markdown
Contributor

@stratakis stratakis commented Mar 23, 2017 •
edited by bedevere-bot
Loading

Patch from @encukou

More info at: http://bugs.python.org/issue23699

Rebased for the current master branch.

https://bugs.python.org/issue23699

@mention-bot
Copy link
Copy Markdown

mention-bot commented Mar 23, 2017

@stratakis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis and @benjaminp to be potential reviewers.

@brettcannon brettcannon added the type-feature A feature request or enhancement label Mar 27, 2017
ncoghlan
ncoghlan approved these changes May 30, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me (reducing the total line count by 250+ lines is a sign of a good pattern extraction), so there's just the Misc/NEWS and Misc/ACKS bookkeeping needed prior to merging.

@stratakis
Copy link
Copy Markdown
Contributor Author

stratakis commented May 30, 2017

Thanks for taking a look at it Nick. Will update the PR with the Misc/NEWS and Misc/ACKS files. Do you think it would be possible to backport this change to the 3.6 branch? Should I make a PR for a backport as well?

@stratakis stratakis force-pushed the richcompare_macro branch from d730285 to c947ff2 Compare May 30, 2017 09:18
@ncoghlan
Copy link
Copy Markdown
Contributor

ncoghlan commented May 30, 2017

No, it's a new feature, so projects will need to either define it themselves or get it from a compatibility project like Py3C for older releases.

@stratakis
Copy link
Copy Markdown
Contributor Author

stratakis commented Oct 23, 2017

PR has been rebased on top of master and the tests pass. Is there some way I can help moving this forward?

@ncoghlan ncoghlan merged commit e8b1965 into python:master Nov 2, 2017
@ncoghlan
Copy link
Copy Markdown
Contributor

ncoghlan commented Nov 2, 2017

Thanks!

@stratakis stratakis deleted the richcompare_macro branch November 2, 2017 10:36
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@stratakis @embray
bpo-23699: Use a macro to reduce boilerplate code in rich comparison …
f0e97da 
…functions (pythonGH-793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@stratakis @mention-bot @ncoghlan @brettcannon @Mariatta @the-knights-who-say-ni @bedevere-bot @encukou