bpo-34829: Add missing selection_ methods to the Tkinter Spinbox#9617
bpo-34829: Add missing selection_ methods to the Tkinter Spinbox#9617serhiy-storchaka merged 6 commits intopython:masterfrom
Conversation
Implement the methods selection_from, selection_range, selection_present and selection_to for Tkinter Spinbox.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add tests, a news entry, a What's New entry, and add your name in Misc/ACKS.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Thank you @j4321. Would be nice to add also tests for existing selection methods and add the same or similar tests for the Entry widget.
| Added methods :meth:`~tkinter.Spinbox.selection_from`, | ||
| :meth:`~tkinter.Spinbox.selection_present`, | ||
| :meth:`~tkinter.Spinbox.selection_range` and | ||
| :meth:`~tkinter.Spinbox.selection_to`, |
There was a problem hiding this comment.
The last comma is redundant.
Please add also (Contributed by ...)
| @@ -0,0 +1,3 @@ | |||
| Add methods ``selection_from``, ``selection_range``, ``selection_present`` | |||
| and ``selection_to`` to the ``tkinter.Spinbox`` for consistency with the | |||
| ``tkinter.Entry`` widget. | |||
There was a problem hiding this comment.
Please add Patch by ....
|
Seems there are whitespace issues in rst files. |
|
@serhiy-storchaka |
|
This looks like a bug. Please open a separate issue. |
| in the :class:`tkinter.Spinbox` class. | ||
| :meth:`~tkinter.Spinbox.selection_range` and | ||
| :meth:`~tkinter.Spinbox.selection_to` | ||
| in the :class:`tkinter.Spinbox` class (Contributed by Juliette Monsel). |
There was a problem hiding this comment.
Add a reference to the issue. Take other entries as a pattern.
| @@ -0,0 +1,401 @@ | |||
| **************************** | |||
| Gennadiy Zlobin | ||
| Doug Zongker | ||
| Peter Åstrand | ||
| Juliette Monsel |
There was a problem hiding this comment.
And the last. Names in this list are in rough alphabetical order by last names. Move your name to the correct place.
There was a problem hiding this comment.
Sorry for all the mistakes and thanks for taking the time to point them out, I'll try to do everything right from the start next time.
|
Thank you for your contribution Juliette! Congratulate with your first commit to CPython! |
Add methods selection_from, selection_range, selection_present and selection_to to the Tkinter Spinbox
for consistency with the Entry widget.
https://bugs.python.org/issue34829