Skip to content

Sandcastle oauth with ion#13403

Open
jjspace wants to merge 8 commits intomainfrom
sandcastle-oauth
Open

Sandcastle oauth with ion#13403
jjspace wants to merge 8 commits intomainfrom
sandcastle-oauth

Conversation

@jjspace
Copy link
Copy Markdown
Contributor

@jjspace jjspace commented Apr 14, 2026

Description

Adds basic Login functionality using ion oauth. This also provides a "User" context for the whole app so other components can depend on the currently logged in user. As a proof of concept there is a new Insert > Access token option with the editor that will add your account's default access token to the current sandcastle when logged in. This will be replaced with a selection modal for multiple tokens later.

This PR replaces the #13079 PR which had a mix of changes that have already been merged.

Currently login is only enabled in local development because we need to set up additional domains and deployments to securely enable in deployed environments.

Issue number and link

Private repo issue

Testing plan

  • run npm run build-sandcastle to build with the new login UI
  • run npm start and open local sandcastle
  • Click Login in the upper right and login with oauth
  • Test importing your token into the editor
    • Clicking the Test fetch will send a request that can be checked in the network tab, this is also temporary
  • Test Logging out and back in
  • Test clicking Deny on the oauth screen
  • Navigate to a specific sandcastle and Log-in and make sure you return to that same sandcastle after the auth page.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace jjspace mentioned this pull request Apr 16, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant