Skip to content

Update test_base64.py from 3.14.4#7624

Open
changjoon-park wants to merge 1 commit intoRustPython:mainfrom
changjoon-park:update-test-base64
Open

Update test_base64.py from 3.14.4#7624
changjoon-park wants to merge 1 commit intoRustPython:mainfrom
changjoon-park:update-test-base64

Conversation

@changjoon-park
Copy link
Copy Markdown

@changjoon-park changjoon-park commented Apr 18, 2026

Syncs Lib/test/test_base64.py with CPython 3.14.4.

Adds coverage for the ignorechars parameter of base64.a85decode:

  • Positive case with ignorechars=b" \n"
  • ValueError when ignorechars is empty or missing chars present in the input
  • TypeError when ignorechars is not bytes (str, None)

Also reorders imports so unittest comes first (matches CPython's ordering).

No RUSTPYTHON markers touched.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 18, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test_base64.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: af0f12d2-c2d0-4d36-a571-f41002c82df6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/base64.py
[x] test: cpython/Lib/test/test_base64.py

dependencies:

  • base64

dependent tests: (51 tests)

  • base64: test_base64 test_email test_gettext test_httpservers test_smtplib test_urllib2 test_urllib2_localnet test_xmlrpc test_zoneinfo
    • email.base64mime:
      • smtplib: test_smtpnet
    • http.server: test_logging test_robotparser
      • pydoc: test_enum test_pydoc
      • wsgiref.simple_server: test_wsgiref
      • xmlrpc.server: test_docxmlrpc
    • logging.handlers: test_concurrent_futures test_pkgutil
    • secrets: test_secrets
    • ssl: test_asyncio test_ftplib test_httplib test_imaplib test_poplib test_ssl test_urllib test_venv
      • asyncio.selector_events: test_asyncio
      • urllib.request: test_http_cookiejar test_pathlib test_sax test_site test_urllib2net test_urllibnet
    • urllib.request:
      • pathlib: test_ast test_dbm_sqlite3 test_ensurepip test_importlib test_launcher test_pathlib test_runpy test_tarfile test_tempfile test_tomllib test_tools test_traceback test_unparse test_winapi test_zipapp test_zipfile test_zstd

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

ShaharNaveh
ShaharNaveh approved these changes Apr 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty:)

@changjoon-park
Copy link
Copy Markdown
Author

changjoon-park commented Apr 18, 2026

ty:)

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@changjoon-park @ShaharNaveh