Closed
Conversation
Member
alxhub
commented
Mar 30, 2026
- fix(forms): use controlValue in NgControl for CVA interop
- feat(forms): shim legacy NG_VALIDATORS into parseErrors for CVA mode
a40f3f4 to
8846a30
Compare
leonsenft
requested changes
Mar 31, 2026
5753f71 to
81264dc
Compare
leonsenft
approved these changes
Apr 3, 2026
Contributor
leonsenft
left a comment
There was a problem hiding this comment.
reviewed-for: fw-general, public-api
use controlValue() instead of value() to ensure that CVA controls see the most recent user input immediately rather than waiting for it to be synchronized after debouncing
- Injected `NG_VALIDATORS` into `FormField` and exposed it via an internal getter. - Created a `computed` signal in `cvaControlCreate` to run legacy validators and map into standard validation errors without generic `as any` type assertions. - Intercepted `registerOnValidatorChange` to trigger updates even when the model value remains unchanged (e.g., going from `null` to `null`). - Added integration tests to verify parse error propagation and reactivity.
Member
Author
|
Caretaker: g3 is "green" |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
kirjs
pushed a commit
that referenced
this pull request
Apr 14, 2026
…67943) - Injected `NG_VALIDATORS` into `FormField` and exposed it via an internal getter. - Created a `computed` signal in `cvaControlCreate` to run legacy validators and map into standard validation errors without generic `as any` type assertions. - Intercepted `registerOnValidatorChange` to trigger updates even when the model value remains unchanged (e.g., going from `null` to `null`). - Added integration tests to verify parse error propagation and reactivity. PR Close #67943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.