Skip to content

fix precision error on voronoi.neighbors#138

Merged
Fil merged 2 commits intomainfrom
fil/fix-137
Mar 4, 2023
Merged

fix precision error on voronoi.neighbors#138
Fil merged 2 commits intomainfrom
fil/fix-137

Conversation

@Fil
Copy link
Copy Markdown
Member

@Fil Fil commented Mar 2, 2023

closes #137

Note that the test

it("voronoi neighbors are clipped", () => {
was in the same situation (a point completely in the corner), and was testing the wrong result 😰

fix built at https://observablehq.com/@d3/voronoi-neighbors-137

cc: @UnluckyNinja

Copy link
Copy Markdown
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the formatting. 😬 I wish I knew how to implement this robustly like delaunator does…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Edges that both sides are clipped sometimes will not be identified as voronoi neighbor

2 participants