Robust circumcenters when the hull is collinear#142
Merged
Conversation
Closed
Member
|
This looks like an improvement. 👍 Is there still going to be an issue when all the points are collinear, since in that case the barycenter of the hull will also be collinear? |
Member
Author
|
The case where n>2 points are all aligned is addressed differently: we detect this case in Line 55 in 48d091f and jitter the points. |
mbostock
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure reported in #141 came from the fact that the first point of the first triangle belonged to the collinear part of the hull, thus making the circumcenters of degenerate triangles (which need to be "projected to the infinite") go to either side arbitrarily. We want them to go "outwards".
The solution suggested here is to make sure we use a non-collinear reference (which I took to be the barycenter of the hull—could have been something else; but the first point of the first triangle was clearly a wrong bet).
I've reduced the test case to:
points = [[10, 190]].concat(Array.from({length: 7}, (d, i) => [i * 80, (i * 50) / 7]))before
after
fixes #141