Skip to content

Code editors#4

Merged
sbkrish merged 30 commits intojavascript-tutorial:masterfrom
DasarathanSampath:patch-2
May 4, 2020
Merged

Code editors#4
sbkrish merged 30 commits intojavascript-tutorial:masterfrom
DasarathanSampath:patch-2

Conversation

@DasarathanSampath
Copy link
Copy Markdown
Contributor

Tamil translation of Code editors

Tamil translation of Code editors
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 23, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team April 23, 2020 18:21
Copy link
Copy Markdown
Member

@sbkrish sbkrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed for this module

Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
DasarathanSampath and others added 22 commits May 1, 2020 10:34
@DasarathanSampath
Copy link
Copy Markdown
Contributor Author

"/done"

@javascript-translate-bot javascript-translate-bot requested a review from a team May 1, 2020 05:27
@sbkrish
Copy link
Copy Markdown
Member

sbkrish commented May 1, 2020

Could you please review this module @gokatz ?

@gokatz
Copy link
Copy Markdown
Contributor

gokatz commented May 1, 2020

sure will have a look

Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
@gokatz gokatz added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 3, 2020
@DasarathanSampath
Copy link
Copy Markdown
Contributor Author

DasarathanSampath commented May 4, 2020

"/done"

1 similar comment
@DasarathanSampath
Copy link
Copy Markdown
Contributor Author

"/done"

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 4, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team May 4, 2020 01:09
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 4, 2020
@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Comment thread 1-js/01-getting-started/3-code-editors/article.md Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 4, 2020

CLA assistant check
All committers have signed the CLA.

@sbkrish sbkrish merged commit 4fe8e82 into javascript-tutorial:master May 4, 2020
@javascript-translate-bot
Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Waiting for changes and /done from PR author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants