Skip to content

bpo-30410: Documentation of sys.stdin/out/err update to reflect change in 3.6#10264

Merged
miss-islington merged 1 commit intopython:masterfrom
lysnikolaou:bpo30410
Feb 14, 2019
Merged

bpo-30410: Documentation of sys.stdin/out/err update to reflect change in 3.6#10264
miss-islington merged 1 commit intopython:masterfrom
lysnikolaou:bpo30410

Conversation

@lysnikolaou
Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou commented Oct 31, 2018

Documentation of sys.stdin/out/err update to reflect change in 3.6 on Windows to use UTF-8.

Wording by Eryk Sun and Paul Moore.

https://bugs.python.org/issue30410

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 31, 2018
@lysnikolaou lysnikolaou force-pushed the bpo30410 branch 2 times, most recently from ae10dfd to 1650289 Compare October 31, 2018 20:26
@zooba zooba added the skip news label Nov 3, 2018
Comment thread Doc/library/sys.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ReST experts (or someone with a build of this) know whether hyphens are handled properly across line breaks? Will this end up as "Non-character" or "Non- character"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure line breaks turn into spaces, just like in HTML.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my local Docs build, it is indeed rendered as "Non- character".
It should now be alright.

Comment thread Doc/library/sys.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure line breaks turn into spaces, just like in HTML.

Comment thread Doc/library/sys.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need clarifying that “this value” is the character encoding. Put the blank line back to make a separate paragraph, or try “you can override the character encoding by . . .”

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

@matrixise
Copy link
Copy Markdown
Member

There is another option, python -X utf-8 this one will enable UTF-8 mode and will override the default encoding on Windows, Linux and macOS.
check here: https://docs.python.org/3/whatsnew/3.7.html#pep-540-forced-utf-8-runtime-mode

Thank you for your contrib.

@lysnikolaou
Copy link
Copy Markdown
Member Author

lysnikolaou commented Nov 4, 2018

Oh alright, I didn't know that. I will update my PR to include this. Thanks for your help.

@pfmoore
Copy link
Copy Markdown
Member

pfmoore commented Nov 30, 2018

My feeling is that this is a bit of a "wall of text" and should probably be reworded for clarity. I've proposed alternative text on the bpo issue.

@lysnikolaou
Copy link
Copy Markdown
Member Author

Since this PR is approved by @pfmoore, could someone maybe merge it?

@csabella
Copy link
Copy Markdown
Contributor

@pfmoore @Mariatta
It looks like Paul approved the latest version of the changes. Can the label be added for @miss-islington to do her magic? Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 5723263 into python:master Feb 14, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-11860 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2019
…e in 3.6 (pythonGH-10264)

Documentation of sys.stdin/out/err update to reflect change in 3.6 on Windows to use UTF-8.

Wording by Eryk Sun and Paul Moore.

https://bugs.python.org/issue30410
(cherry picked from commit 5723263)

Co-authored-by: Lysandros Nikolaou <[email protected]>
miss-islington added a commit that referenced this pull request Feb 14, 2019
…e in 3.6 (GH-10264)

Documentation of sys.stdin/out/err update to reflect change in 3.6 on Windows to use UTF-8.

Wording by Eryk Sun and Paul Moore.

https://bugs.python.org/issue30410
(cherry picked from commit 5723263)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@lysnikolaou lysnikolaou deleted the bpo30410 branch May 13, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants