Skip to content

bpo-35153: Add headers to xmlrpc.client.ServerProxy#10308

Merged
vstinner merged 1 commit intopython:masterfrom
cedk:xmlrpc-client-headers
Feb 19, 2019
Merged

bpo-35153: Add headers to xmlrpc.client.ServerProxy#10308
vstinner merged 1 commit intopython:masterfrom
cedk:xmlrpc-client-headers

Conversation

@cedk
Copy link
Copy Markdown
Contributor

@cedk cedk commented Nov 3, 2018 •
edited by bedevere-bot
Loading

Allow to add headers to xmlrpc requests sent to the server.

https://bugs.python.org/issue35153

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Nov 3, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@cedk cedk force-pushed the xmlrpc-client-headers branch from e7e416c to 702e8b7 Compare November 3, 2018 11:38
matrixise
matrixise requested changes Nov 3, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add some tests for the headers in Lib/test/test_xmlrpc.py.

Thank you

Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2018-11-03-12-38-03.bpo-35153.009pdF.rst Outdated
@cedk cedk force-pushed the xmlrpc-client-headers branch 3 times, most recently from c1031fc to 79f63fb Compare November 3, 2018 13:01
methane
methane reviewed Feb 18, 2019
View reviewed changes
Comment thread Lib/test/test_xmlrpc.py Outdated
methane
methane approved these changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane added type-feature A feature request or enhancement 🤖 automerge and removed awaiting merge labels Feb 18, 2019
vstinner
vstinner requested changes Feb 18, 2019
View reviewed changes
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2018-11-03-12-38-03.bpo-35153.009pdF.rst Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 18, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cedk cedk force-pushed the xmlrpc-client-headers branch 3 times, most recently from 02fc2d0 to 6a846c8 Compare February 18, 2019 12:55
pganssle
pganssle requested changes Feb 18, 2019
View reviewed changes
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Lib/test/test_xmlrpc.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 18, 2019
View reviewed changes
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Lib/xmlrpc/client.py Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Lib/xmlrpc/client.py Outdated
Comment thread Lib/xmlrpc/client.py Outdated
Comment thread Lib/xmlrpc/client.py Outdated
@cedk cedk force-pushed the xmlrpc-client-headers branch 2 times, most recently from d2bce34 to 2b55c91 Compare February 18, 2019 15:54
@cedk cedk force-pushed the xmlrpc-client-headers branch from 2b55c91 to 92b2b0c Compare February 18, 2019 16:46
vstinner
vstinner approved these changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's now better documented and safer thanks to keyword-only parameters!

I just have proposed a minor change on the NEWS entry.

Comment thread Misc/NEWS.d/next/Library/2018-11-03-12-38-03.bpo-35153.009pdF.rst Outdated
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 18, 2019

Since @serhiy-storchaka and @pganssle asked for changes, I wait for them to review the updated PR.

@cedk cedk force-pushed the xmlrpc-client-headers branch from 92b2b0c to 59b35e0 Compare February 19, 2019 00:10
serhiy-storchaka
serhiy-storchaka reviewed Feb 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"argument" is what passed when call a function. "parameter" is what specified in function declaration and used in function.

Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2018-11-03-12-38-03.bpo-35153.009pdF.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Feb 19, 2019

LGTM except few nitpicks.

@cedk cedk force-pushed the xmlrpc-client-headers branch from 59b35e0 to 2209bbf Compare February 19, 2019 09:16
pganssle
pganssle reviewed Feb 19, 2019
View reviewed changes
Comment thread Lib/test/test_xmlrpc.py Outdated
@cedk cedk force-pushed the xmlrpc-client-headers branch from 2209bbf to cd91d19 Compare February 19, 2019 14:14
pganssle
pganssle reviewed Feb 19, 2019
View reviewed changes
Comment thread Lib/test/test_xmlrpc.py Outdated
@cedk
bpo-35153: Add headers to xmlrpc.client.ServerProxy
b777524 
Allow to add headers to xmlrpc requests sent to the server.
@cedk cedk force-pushed the xmlrpc-client-headers branch from cd91d19 to b777524 Compare February 19, 2019 15:21
pganssle
pganssle approved these changes Feb 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good to me. Thanks for your contribution and your patience with the code review process @cedk!

@vstinner vstinner merged commit beda52e into python:master Feb 19, 2019
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 19, 2019

Well done @cedk! I merged your PR. Thanks for your nice enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@matrixise matrixise matrixise requested changes

@vstinner vstinner vstinner approved these changes

@methane methane methane approved these changes

@pganssle pganssle pganssle approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cedk @the-knights-who-say-ni @bedevere-bot @vstinner @serhiy-storchaka @matrixise @methane @pganssle