Skip to content

bpo-35283: Add the "isAlive" alias for _DummyThread #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 1 commit into from
Closed

bpo-35283: Add the "isAlive" alias for _DummyThread #10653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ def f(mutex):
self.assertIsInstance(threading._active[tid], threading._DummyThread)
#Issue 29376
self.assertTrue(threading._active[tid].is_alive())
#Issue 35283
self.assertTrue(threading._active[tid].isAlive())
self.assertRegex(repr(threading._active[tid]), '_DummyThread')
del threading._active[tid]

Expand Down
2 changes: 2 additions & 0 deletions Lib/threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,6 +1197,8 @@ def is_alive(self):
assert not self._is_stopped and self._started.is_set()
return True

isAlive = is_alive

def join(self, timeout=None):
assert False, "cannot join a dummy thread"

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-11-22-20-14-14.bpo-35283.OBqxuw.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add the "isAlive" alias for _DummyThread