bpo-35345: Remove platform.popen()#10781
Merged
vstinner merged 4 commits intopython:masterfrom Nov 29, 2018
vstinner:remove_platform_popen
Merged
bpo-35345: Remove platform.popen()#10781vstinner merged 4 commits intopython:masterfrom vstinner:remove_platform_popen
vstinner merged 4 commits intopython:masterfrom
vstinner:remove_platform_popen
Conversation
Remove platform.popen() function, it was deprecated since Python 3.3: use os.popen() instead.
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM except What's New entries. This is not new feature, and is not changing behavior of existing feature. I think the only entry should be added into the "Removed" section.
Rename also the "Removed" section to "API and Feature Removals": copy title from What's New in Python 3.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove platform.popen() function, it was deprecated since Python 3.3:
use os.popen() instead.
https://bugs.python.org/issue35345