Skip to content

gh-112387: Fix error positions for decoded strings with backwards tokenize errors#112409

Merged
pablogsal merged 1 commit intopython:mainfrom
pablogsal:gh-112387
Nov 27, 2023
Merged

gh-112387: Fix error positions for decoded strings with backwards tokenize errors#112409
pablogsal merged 1 commit intopython:mainfrom
pablogsal:gh-112387

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Nov 25, 2023

Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit 45d6485 into python:main Nov 27, 2023
@pablogsal pablogsal deleted the gh-112387 branch November 27, 2023 18:37
@miss-islington-app
Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
…ds tokenize errors (pythonGH-112409)

(cherry picked from commit 45d6485)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Nov 27, 2023

GH-112468 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
…ds tokenize errors (pythonGH-112409)

(cherry picked from commit 45d6485)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 27, 2023
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Nov 27, 2023

GH-112469 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 27, 2023
pablogsal added a commit that referenced this pull request Nov 27, 2023
…rds tokenize errors (GH-112409) (#112468)

gh-112387: Fix error positions for decoded strings with backwards tokenize errors (GH-112409)
(cherry picked from commit 45d6485)

Signed-off-by: Pablo Galindo <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Nov 27, 2023
…rds tokenize errors (GH-112409) (#112469)

gh-112387: Fix error positions for decoded strings with backwards tokenize errors (GH-112409)
(cherry picked from commit 45d6485)

Signed-off-by: Pablo Galindo <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants