GH-112498 Add heapremove and heapfix#112550
Closed
kristjanvalur wants to merge 15 commits intopython:mainfrom
Closed
GH-112498 Add heapremove and heapfix#112550kristjanvalur wants to merge 15 commits intopython:mainfrom
kristjanvalur wants to merge 15 commits intopython:mainfrom
Conversation
584fb09 to
d422535
Compare
13dca1f to
0f50d70
Compare
84cd1a4 to
bc1d67e
Compare
bc1d67e to
91c42e4
Compare
91c42e4 to
7dbceb0
Compare
StanFromIreland
requested changes
Sep 27, 2025
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
I think max heaps should have an equivalent API to avoid confusion.
|
|
||
| Raises :exc:`ValueError` if no item corresponding to *value* is found. | ||
|
|
||
| .. versionadded:: 3.13 |
Member
There was a problem hiding this comment.
Please change these to next
|
|
||
| The heap is searched for the first item comparing equal to *value*. | ||
|
|
||
| If the _callable_ *key* is provided, it will be called for each item |
Member
There was a problem hiding this comment.
This is restructured text, underscores will not work.
Contributor
Author
|
this PR is two years old, not sure there is any interest in pursuing it. It was at best lukewarm at the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #112497 which adds two functions,
heapfixandheapremove.This is perhaps better, since the use cases are different.
heappopbecomes a special case ofheapremoveandIt corresponds to what golang does in https://pkg.go.dev/container/heap
📚 Documentation preview 📚: https://cpython-previews--112550.org.readthedocs.build/