gh-65701: document that freeze doesn't work with framework builds on macOS#113352
Merged
ronaldoussoren merged 4 commits intopython:mainfrom Dec 21, 2023
Merged
gh-65701: document that freeze doesn't work with framework builds on macOS#113352ronaldoussoren merged 4 commits intopython:mainfrom
ronaldoussoren merged 4 commits intopython:mainfrom
Conversation
…ds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway.
Contributor
Author
|
I looked into adding a test for this, but in the end skipped this: the test machinery for the freeze tool performs a build & install into a temporary directory and that doesn't work with framework builds either. That's not something I want to debug further given that the test would only check that the tool does not work. |
erlend-aasland
approved these changes
Dec 21, 2023
Contributor
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM. Added a suggestion to use the :program: role.
…bN.rst Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2023
…ds on macOS (pythonGH-113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. (cherry picked from commit df1eec3) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-113361 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2023
…ds on macOS (pythonGH-113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. (cherry picked from commit df1eec3) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-113362 is a backport of this pull request to the 3.12 branch. |
ronaldoussoren
added a commit
that referenced
this pull request
Dec 22, 2023
…lds on macOS (GH-113352) (#113362) gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352) * gh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. (cherry picked from commit df1eec3) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
ronaldoussoren
added a commit
that referenced
this pull request
Dec 22, 2023
…lds on macOS (GH-113352) (#113361) gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352) * gh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. (cherry picked from commit df1eec3) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…ds on macOS (python#113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. Co-authored-by: Erlend E. Aasland <[email protected]>
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…ds on macOS (python#113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. Co-authored-by: Erlend E. Aasland <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ds on macOS (python#113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. Co-authored-by: Erlend E. Aasland <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ds on macOS (python#113352) * pythongh-65701: document that freeze doesn't work with framework builds on macOS The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway. Co-authored-by: Erlend E. Aasland <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway.