Skip to content

bpo-35283: Update the docstring of threading.Thread.join method#11596

Merged
vstinner merged 1 commit intopython:masterfrom
corona10:join_docstring
Jan 18, 2019
Merged

bpo-35283: Update the docstring of threading.Thread.join method#11596
vstinner merged 1 commit intopython:masterfrom
corona10:join_docstring

Conversation

@corona10
Copy link
Copy Markdown
Member

@corona10 corona10 commented Jan 17, 2019

@corona10 corona10 changed the title bpo-35283: Update the docstring of threading.Thread.isAlive method bpo-35283: Update the docstring of threading.Thread.join method Jan 17, 2019
@corona10
Copy link
Copy Markdown
Member Author

@vstinner @asvetlov
I found that the docstring of threading.Thread.join should be updated to use is_alive.
And also it needs to apply 3.x versions. What do you think?

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the NEWS entry. It's not worth it. I will add "skip news" label instead.

@corona10
Copy link
Copy Markdown
Member Author

@vstinner
I remove the NEWS entry as you comment.
Thanks always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants