Skip to content

bpo-32627: Fix compile error when _uuid headers conflicting included#11751

Merged
ned-deily merged 2 commits intopython:masterfrom
zihengCat:bpo-32627
Jun 24, 2019
Merged

bpo-32627: Fix compile error when _uuid headers conflicting included#11751
ned-deily merged 2 commits intopython:masterfrom
zihengCat:bpo-32627

Conversation

@zihengCat
Copy link
Copy Markdown
Contributor

@zihengCat zihengCat commented Feb 3, 2019

A compile error occurred when operating system both have uuid.h and uuid/uuid.h.

  • Versions: Python 3.8, Python 3.7

https://bugs.python.org/issue32627

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We need wait for a core dev review it.

Please, sign CLA.

@zihengCat
Copy link
Copy Markdown
Contributor Author

@eamanu
I couldn't compile Python3.7 successfully in CentOS 7 Linux because of this bug, seems that it's also occurred in Fedora as well as NetBSD.

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @zihengCat for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @zihengCat for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-14347 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2019
@bedevere-bot
Copy link
Copy Markdown

GH-14348 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 24, 2019
miss-islington added a commit that referenced this pull request Jun 24, 2019
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jul 2, 2019
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants