bpo-26243: data= is positional-only just on CPython#11754
Closed
ambv wants to merge 1 commit intopython:mainfrom
Closed
bpo-26243: data= is positional-only just on CPython#11754ambv wants to merge 1 commit intopython:mainfrom
ambv wants to merge 1 commit intopython:mainfrom
Conversation
PyPy can take it as keyword just fine.
Member
|
I think it would be more correct to remove too strong failing assertions. Other tests should be passed on PyPy. |
mozillazg
pushed a commit
to mozillazg/pypy
that referenced
this pull request
Feb 4, 2019
eamanu
approved these changes
Feb 5, 2019
Contributor
eamanu
left a comment
There was a problem hiding this comment.
LGTM. I test it on ubuntu 18.04 and its good.
pitrou
reviewed
Feb 6, 2019
| x = zlib.compress(HAMLET_SCENE) | ||
| self.assertEqual(zlib.decompress(x), HAMLET_SCENE) | ||
|
|
||
| @support.cpython_only |
Member
There was a problem hiding this comment.
It's only the TypeError check that should be skipped, right? Not the whole test.
| self.assertIsInstance(dco.unconsumed_tail, bytes) | ||
| self.assertIsInstance(dco.unused_data, bytes) | ||
|
|
||
| @support.cpython_only |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPy can take it as keyword just fine.
https://bugs.python.org/issue26243