Skip to content

bpo-24209: In http.server script, rely on getaddrinfo to bind to preferred address based on the bind parameter.#11767

Merged
jaraco merged 8 commits intopython:masterfrom
jaraco:feature/http-server-bind-ipv6
Feb 7, 2019
Merged

bpo-24209: In http.server script, rely on getaddrinfo to bind to preferred address based on the bind parameter.#11767
jaraco merged 8 commits intopython:masterfrom
jaraco:feature/http-server-bind-ipv6

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Feb 6, 2019 •
edited by bedevere-bot
Loading

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Feb 6, 2019

With this patch, I see this behavior:

cpython feature/http-server-bind-ipv6 $ ./python.exe -m http.server --bind localhost                                                                                                     
Serving HTTP on ::1 port 8000 (http://::1:8000/) ...
^C
Keyboard interrupt received, exiting.
cpython feature/http-server-bind-ipv6 $ ./python.exe -m http.server                                                                                                                      
Serving HTTP on :: port 8000 (http://:::8000/) ...
^C
Keyboard interrupt received, exiting.

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Feb 6, 2019

@lisroach Since you reviewed and submitted the last PR on this issue, would you care to comment on or review this also?

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Feb 7, 2019

I'm inclined to proceed with the merge, but happy to iterate further as needed.

@jaraco jaraco merged commit f289084 into python:master Feb 7, 2019
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 7, 2019

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@jaraco jaraco deleted the feature/http-server-bind-ipv6 branch February 7, 2019 13:23
@rathann
Copy link
Copy Markdown

rathann commented Mar 21, 2020

Will this be backported to 3.7?

@zajdee zajdee mentioned this pull request Jul 24, 2020
Closed
@AluisioASG AluisioASG mentioned this pull request Nov 29, 2020
Open
@csmarchbanks csmarchbanks mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaraco @bedevere-bot @rathann @the-knights-who-say-ni