bpo-36320: Switch typing.NamedTuple from OrderedDict to regular dict#12396
Merged
miss-islington merged 3 commits intopython:masterfrom Mar 18, 2019
Merged
bpo-36320: Switch typing.NamedTuple from OrderedDict to regular dict#12396miss-islington merged 3 commits intopython:masterfrom
miss-islington merged 3 commits intopython:masterfrom
Conversation
ilevkivskyi
approved these changes
Mar 18, 2019
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! I just have one suggestion about docs.
| ``_fields`` attribute, which is part of the namedtuple API.) | ||
| The resulting class has an extra attribute ``__annotations__`` giving a | ||
| dict that maps the field names to the field types. (The field names are in | ||
| the ``_fields`` attribute, which is part of the namedtuple API.) |
Member
There was a problem hiding this comment.
Previously _field_defaults were also mentioned, maybe also keep them mentioned as "part of the namedtuple API"?
gvanrossum
approved these changes
Mar 18, 2019
Member
gvanrossum
left a comment
There was a problem hiding this comment.
I agree with the idea. I have no time for a thorough code review, but you got that from Ivan.
Contributor
|
@rhettinger: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, deprecate the _field_types attributes which duplicated the information in _annotations_.
https://bugs.python.org/issue36320