Skip to content

bpo-36350: inspect: Replace OrderedDict with dict.#12412

Merged
methane merged 8 commits intopython:masterfrom
remilapeyre:inpect.Signature-BoundArguments-ordereddict
Jan 28, 2020
Merged

bpo-36350: inspect: Replace OrderedDict with dict.#12412
methane merged 8 commits intopython:masterfrom
remilapeyre:inpect.Signature-BoundArguments-ordereddict

Conversation

@remilapeyre
Copy link
Copy Markdown

@remilapeyre remilapeyre commented Mar 18, 2019 •
edited by bedevere-bot
Loading

matrixise
matrixise reviewed Mar 18, 2019
View reviewed changes
Comment thread Lib/inspect.py
tirkarthi
tirkarthi reviewed Mar 18, 2019
View reviewed changes
Comment thread Lib/inspect.py
@remilapeyre remilapeyre reopened this Mar 18, 2019
rhettinger
rhettinger requested changes Mar 18, 2019
View reviewed changes
Comment thread Doc/library/inspect.rst Outdated
Comment thread Lib/inspect.py
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 18, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre remilapeyre force-pushed the inpect.Signature-BoundArguments-ordereddict branch from aa77813 to caaf117 Compare March 18, 2019 16:50
@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Mar 20, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 20, 2019

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@csabella csabella requested a review from rhettinger January 25, 2020 20:14
methane
methane requested changes Jan 28, 2020
View reviewed changes
Comment thread Doc/library/inspect.rst Outdated
Comment thread Doc/library/inspect.rst Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 28, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@methane methane changed the title bpo-36350: Change type of inspect.{Signature.parameters,BoundArguments.arguments} bpo-36350: inspect: Replace OrderedDict with dict. Jan 28, 2020
Rémi Lapeyre and others added 2 commits January 28, 2020 13:21
@methane
Update versionchanged
f4d4564 
Co-Authored-By: Inada Naoki <[email protected]>
@methane
Update versionchanged
e81f405 
Co-Authored-By: Inada Naoki <[email protected]>
@methane methane merged commit 2cca8ef into python:master Jan 28, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@shihai1991
bpo-36350: inspect: Replace OrderedDict with dict. (pythonGH-12412)
4fcf330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise left review comments

@tirkarthi tirkarthi tirkarthi left review comments

@methane methane methane approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@remilapeyre @bedevere-bot @matrixise @methane @rhettinger @tirkarthi @the-knights-who-say-ni