bpo-30661: Improve doc for tarfile pax change and effect on shutil#12635
Merged
ncoghlan merged 1 commit intopython:masterfrom Apr 7, 2019
Merged
bpo-30661: Improve doc for tarfile pax change and effect on shutil#12635ncoghlan merged 1 commit intopython:masterfrom
ncoghlan merged 1 commit intopython:masterfrom
Conversation
vadmium
reviewed
Mar 31, 2019
Member
There was a problem hiding this comment.
Was doubling modern meant to distract me from noticing 2001 is eighteen years ago? :)
Member
Author
There was a problem hiding this comment.
Heh. "modern"-est, I suppose, although to be fair it took even libarchive (modern bsdtar) 10 years to implement fully complete support (ironically, GNU tar had it far earlier). And would you believe I've worked as a freelance copyeditor?
In any case, fixed, thanks.
27aa509 to
cd8672f
Compare
ncoghlan
approved these changes
Apr 7, 2019
Contributor
ncoghlan
left a comment
There was a problem hiding this comment.
Thanks! And I agree this doesn't need a separate NEWS item - it's covered by the existing one for the tarfile change, as it's just updating the docs to explain shutil inherits that change in defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to bpo-36268 and PR #12355 , to fully resolve bpo-30661 this PR makes the following documentation changes:
tarshutil.make_archiveformat, and adds aversionchangednote to this effect toshutil.make_archive.shutilsection of the What's New document.versionchangedsection there.I didn't add a
NEWSitem for this change, but I can do so if desired (@ncoghlan ?).https://bugs.python.org/issue30661