bpo-30158: Fix deprecation warnings in test_importlib introduced by …#1285
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Apr 29, 2017
Merged
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ericsnowcurrently and @Carreau to be potential reviewers. |
Member
|
While ignoring the warning on find_module() and find_loader() tests make sense, I'm not sure about tests using find_module/find_loader. Should these tests be updated to use find_spec()? |
Member
Author
|
I don't know. |
brettcannon
approved these changes
Apr 28, 2017
Member
|
It looks like the whole module is a bit lacking on the |
Member
|
"I opened https://bugs.python.org/issue30202 to track that." Thanks Brett for that ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bpo-29576.