bpo-36707: Remove "m" flag from SOABI#12931
Merged
vstinner merged 1 commit intopython:masterfrom Apr 24, 2019
vstinner:pymalloc_soabi
Merged
bpo-36707: Remove "m" flag from SOABI#12931vstinner merged 1 commit intopython:masterfrom vstinner:pymalloc_soabi
vstinner merged 1 commit intopython:masterfrom
vstinner:pymalloc_soabi
Conversation
warsaw
approved these changes
Apr 24, 2019
Member
Author
|
@warsaw: I updated my PR, would you mind to review it again? |
"./configure --with-pymalloc" no longer adds the "m" flag to SOABI (sys.implementation.cache_tag). Enabling or disabling pymalloc has no impact on the ABI.
Member
Author
|
Oh, I missed the comment proposing the add "the" and fixing a typo (add => adds). Both are now fixed. |
methane
approved these changes
Apr 24, 2019
Member
Author
stefanor
added a commit
to stefanor/line_profiler
that referenced
this pull request
Nov 3, 2020
Erotemic
pushed a commit
to pyutils/line_profiler
that referenced
this pull request
Nov 3, 2020
* Test on Python 3.9 * Python 3.9 dropped gettimeofday configure checks In bpo-38068, cPython assumes gettimeofday exists and takes two arguments. That's a reasonable assumption that we can repeat. See: python/cpython@f1c1903 * Drop Python 3.5 from Travis Python 3.5 is end of life, and the test stack is no longer installing. * The m flag was dropped in 3.8, this wasn't a once-off abnormality See: python/cpython#12931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./configure --with-pymalloc no longer add "m" flag to SOABI:
enabling or disabling pymalloc has no impact on the ABI.
https://bugs.python.org/issue36707