bpo-36772 Allow lru_cache to be used as decorator without making a function call#13048
Merged
rhettinger merged 5 commits intopython:masterfrom May 26, 2019
Merged
bpo-36772 Allow lru_cache to be used as decorator without making a function call#13048rhettinger merged 5 commits intopython:masterfrom
rhettinger merged 5 commits intopython:masterfrom
Conversation
ericvsmith
reviewed
May 2, 2019
Member
ericvsmith
left a comment
There was a problem hiding this comment.
Other than the one nit I noted, this looks good to me.
Member
|
To avoid misuse of the decorator, def lru_cache(*args, **kwargs):
if not kwargs and len(args) == 1 and callable(args[0]):
return lru_cache_impl()(args[0])
return lru_cache_impl(*args, **kwargs)
lru_cache.__text_signature__ = '(maxsize=128, typed=False)'
def lru_cache_impl(maxsize=128, typed=False):
... # the current implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36772