gh-72902: speedup Fraction.from_decimal/float in typical cases#133251
Open
skirpichev wants to merge 2 commits intopython:mainfrom
Open
gh-72902: speedup Fraction.from_decimal/float in typical cases#133251skirpichev wants to merge 2 commits intopython:mainfrom
skirpichev wants to merge 2 commits intopython:mainfrom
Conversation
Member
Author
Here patch2 is the current version. v1 had a hack to check Details# bench.py
import pyperf
from fractions import Fraction as F
from decimal import Decimal as D
from numbers import Integral
runner = pyperf.Runner()
s = 'Fraction.from_decimal'
f = F.from_decimal
class myint:
numerator = 123
denominator = 1
def __int__(self):
return 123
def __repr__(self):
return "myint"
Integral.register(myint)
for v in [1, myint(), D(1)]:
r = s + '(' + repr(v) + ')'
runner.bench_func(r, f, v)
s = 'Fraction.from_float'
f = F.from_float
for v in [1, myint(), 1.1]:
r = s + '(' + repr(v) + ')'
runner.bench_func(r, f, v)diff --git a/Lib/fractions.py b/Lib/fractions.py
index fa722589fb..d7887af9f8 100644
--- a/Lib/fractions.py
+++ b/Lib/fractions.py
@@ -335,23 +335,23 @@ def from_float(cls, f):
Beware that Fraction.from_float(0.3) != Fraction(3, 10).
"""
- if isinstance(f, numbers.Integral):
+ if not isinstance(f, float):
+ if not isinstance(f, (int, numbers.Integral)):
+ raise TypeError("%s.from_float() only takes floats, not %r (%s)" %
+ (cls.__name__, f, type(f).__name__))
return cls(f)
- elif not isinstance(f, float):
- raise TypeError("%s.from_float() only takes floats, not %r (%s)" %
- (cls.__name__, f, type(f).__name__))
return cls._from_coprime_ints(*f.as_integer_ratio())
@classmethod
def from_decimal(cls, dec):
"""Converts a finite Decimal instance to a rational number, exactly."""
from decimal import Decimal
- if isinstance(dec, numbers.Integral):
- dec = Decimal(int(dec))
- elif not isinstance(dec, Decimal):
- raise TypeError(
- "%s.from_decimal() only takes Decimals, not %r (%s)" %
- (cls.__name__, dec, type(dec).__name__))
+ if not isinstance(dec, Decimal):
+ if not isinstance(dec, (int, numbers.Integral)):
+ raise TypeError(
+ "%s.from_decimal() only takes Decimals, not %r (%s)" %
+ (cls.__name__, dec, type(dec).__name__))
+ dec = int(dec)
return cls._from_coprime_ints(*dec.as_integer_ratio())
@classmethod |
Member
Author
|
This is a second part of improvements, cherry-picked from the issue thread. I think this is less controversial, as speedup affects main use-cases (i.e. Decimal's or float's, respectively). With v2 version we haven't speed regressions for integer case. Though, I'm not sure about using that hack. |
Contributor
This is slightly slower: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.