Skip to content

bpo-18911: using xmlcharrefreplace when open a file#13352

Merged
scoder merged 2 commits intopython:masterfrom
Windsooon:bpo-18911
Jun 1, 2019
Merged

bpo-18911: using xmlcharrefreplace when open a file#13352
scoder merged 2 commits intopython:masterfrom
Windsooon:bpo-18911

Conversation

@Windsooon
Copy link
Copy Markdown
Contributor

@Windsooon Windsooon commented May 16, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 16, 2019
@csabella csabella requested a review from scoder May 16, 2019 13:17
scoder
scoder requested changes May 31, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not recommend using the replacement method. See my comment in the ticket.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 31, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Windsooon
Copy link
Copy Markdown
Contributor Author

Windsooon commented Jun 1, 2019

@scoder I updated the PR base on your review and suggestions.

@scoder scoder merged commit 5ac0b98 into python:master Jun 1, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 1, 2019

Thanks @Windsooon for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 1, 2019

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 1, 2019

Thanks @Windsooon for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2019
@Windsooon @miss-islington
bpo-18911: clarify that the minidom XML writer receives texts but not…
876f109 
… bytes (pythonGH-13352)

(cherry picked from commit 5ac0b98)

Co-authored-by: Windson yang <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 1, 2019

GH-13718 is a backport of this pull request to the 3.7 branch.

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Jun 1, 2019

Thanks @Windsooon!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@Windsooon @DinoV
bpo-18911: clarify that the minidom XML writer receives texts but not…
b005f21 
… bytes (pythonGH-13352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scoder scoder scoder approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Windsooon @bedevere-bot @miss-islington @scoder @auvipy @the-knights-who-say-ni @sunkistone